Polish micrometer-metricsgh-5605 (micrometer-metrics#5738)

jonatan-ivanov · Dec 9, 2024 · f58d4bc · f58d4bc
1 parent 0f04214
commit f58d4bc
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/docs/src/test/java/io/micrometer/docs/observation/ObservationTestingTests.java b/docs/src/test/java/io/micrometer/docs/observation/ObservationTestingTests.java
@@ -88,7 +88,7 @@ static class Example {
         }
 
         void run() {
-            final Observation observation = Observation.createNotStarted("foo", registry)
+            Observation observation = Observation.createNotStarted("foo", registry)
                     .lowCardinalityKeyValue("lowTag", "lowTagValue")
                     .highCardinalityKeyValue("highTag", "highTagValue");
             observation.observe(() -> {

diff --git a/...observation-test/src/main/java/io/micrometer/observation/tck/TestObservationRegistry.java b/...observation-test/src/main/java/io/micrometer/observation/tck/TestObservationRegistry.java
@@ -121,7 +121,7 @@ public boolean supportsContext(Observation.Context context) {
         }
 
         @Override
-        public void onEvent(final Observation.Event event, final Observation.Context context) {
+        public void onEvent(Observation.Event event, Observation.Context context) {
             this.contexts.stream()
                 .filter(testContext -> testContext.getContext() == context)
                 .findFirst()

diff --git a/...ation-test/src/main/java/io/micrometer/observation/tck/TestObservationRegistryAssert.java b/...ation-test/src/main/java/io/micrometer/observation/tck/TestObservationRegistryAssert.java
@@ -581,6 +581,7 @@ public TestObservationRegistryAssert backToTestObservationRegistry() {
          * @return this
          * @throws AssertionError if the {@link Observation} does not have an event with
          * the given name
+         * @since 1.15.0
          */
         public TestObservationRegistryAssertReturningObservationContextAssert hasEvent(String name) {
             isNotNull();
@@ -598,6 +599,7 @@ public TestObservationRegistryAssertReturningObservationContextAssert hasEvent(S
          * @return this
          * @throws AssertionError if the {@link Observation} does not have an event with
          * the given name and contextual name
+         * @since 1.15.0
          */
         public TestObservationRegistryAssertReturningObservationContextAssert hasEvent(String name,
                 String contextualName) {
@@ -616,6 +618,7 @@ public TestObservationRegistryAssertReturningObservationContextAssert hasEvent(S
          * @return this
          * @throws AssertionError if the {@link Observation} has an event with the given
          * name
+         * @since 1.15.0
          */
         public TestObservationRegistryAssertReturningObservationContextAssert doesNotHaveEvent(String name) {
             isNotNull();
@@ -629,10 +632,11 @@ public TestObservationRegistryAssertReturningObservationContextAssert doesNotHav
          * Verifies that the {@link Observation} does not have an event with the given
          * name and contextual name.
          * @param name event name
-         * @param contextualName contextual name@
+         * @param contextualName contextual name
          * @return this
          * @throws AssertionError if the {@link Observation} has an event with the given
          * name and contextual name
+         * @since 1.15.0
          */
         public TestObservationRegistryAssertReturningObservationContextAssert doesNotHaveEvent(String name,
                 String contextualName) {