Adding parser for InfoReply and ClientListReply #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for line in data.splitlines(): | ||
| pairs = line.split(b" ") | ||
| client_info = {} | ||
| print(pairs) |
There was a problem hiding this comment.
Could you remove this print statement?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I've a need for handling data contained in InfoReply object. Since the parser is on the TODO list, I wish to implement it. I also took the time to implement a parser for ClientListReply object.
These are naive parsers, all of the value are displayed as
bytesstring (no attempts of type conversion). The data structures are pretty straight forward:dictcontaining all the key/value pair found in the reply. The sections, the lines starting withb"# ", are not used as keys here. I don't know if we should do something like thatinfo = {section_name1: {section_key1, section_value2}, section_name2: {...}, }instead.listofdict, each element of the list representing a clientI make this Pull Request to discuss the implementation of these parsers, thus if you have any suggestion about it (since this implementation will do the job for my project), I'll be pleased to modifiy it.
Naturally, the tests will be written once the design has been validated.
Cheers,