Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.8; drop Python <3.6 #135

Merged
merged 21 commits into from
Jan 22, 2020

Conversation

crusaderky
Copy link
Contributor

@crusaderky crusaderky commented Jan 15, 2020

  • Closes Python 3.8 DeprecationWarnings; drop support for legacy Python #133
  • Added support for Python 3.8
  • Dropped support for Python <3.6
  • Deprecated 'loop' parameter in Connection.create and Pool.create
  • Fixed all DeprecationWarnings
  • Fix missing object asyncio.streams.IncompleteReadError
  • Fixed all Sphinx build errors and warnings
  • Intersphinx: all classes that can be imported from the top-level module must now be
    referenced from the top-level module in the docstrings too.
    E.g. :class:`asyncio_redis.exceptions.Error` has changed to
    :class:`asyncio_redis.Error` .

@crusaderky crusaderky changed the title WIP Add Python 3.8; drop Python <3.6 Add Python 3.8; drop Python <3.6 Jan 15, 2020
@crusaderky
Copy link
Contributor Author

@jonathanslenders ready for review

@crusaderky
Copy link
Contributor Author

Hi @jonathanslenders, any feedback on this?

@jonathanslenders
Copy link
Owner

Hi @crusaderky,

Thank you so much for this! It looks great.
If you think it's ready and well tested, I can merge it.

@crusaderky
Copy link
Contributor Author

@jonathanslenders I tested it in my Python 3.8 project, which however uses only a tiny subset of the methods, and it seems to work fine. For everything else, we have to rely on the unit tests. I'd say merge...

CHANGELOG Outdated Show resolved Hide resolved
CHANGELOG Show resolved Hide resolved
CHANGELOG Show resolved Hide resolved
@jonathanslenders jonathanslenders merged commit 3658972 into jonathanslenders:master Jan 22, 2020
@jonathanslenders
Copy link
Owner

Merged! Thanks a lot for this!

@crusaderky crusaderky deleted the py38 branch January 23, 2020 17:20
@jbasko
Copy link

jbasko commented May 2, 2020

This was never released, was it? Is the idea to use a version pointing to git commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.8 DeprecationWarnings; drop support for legacy Python
3 participants