Patch 1 #74
Open
Patch 1 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonblack
requested changes
Apr 11, 2018
| @@ -217,6 +217,46 @@ class MenuItem : public MenuComponent { | |||
| virtual Menu* select(); | |||
| }; | |||
|
|
|||
| class TextMenuItem : public MenuItem { | |||
There was a problem hiding this comment.
What benefit does a TextMenuItem have over using multiple MenuItem's and cycling between them?
There was a problem hiding this comment.
I'm also not a fan of the name since a MenuItem is really a menu item with some text. This is more like a combo box or select box. So if it is useful, I'd prefer a different name.
| // ********************************************************* | ||
|
|
||
| TextMenuItem::TextMenuItem(const char* name, SelectFnPtr select_fn) | ||
| : MenuItem(name, select_fn),current_value_id(0) { |
There was a problem hiding this comment.
One initialization list item per line. See other classes for example.
| String _value; | ||
| int current_value_id; | ||
| char** _values; | ||
| int count; |
There was a problem hiding this comment.
All private member variable should be prefixed with an underscore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.