Skip to content

Commit

Permalink
Remove the --offline flag from uv python install
Browse files Browse the repository at this point in the history
  • Loading branch information
jond01 committed Sep 12, 2024
1 parent 6e2c1d2 commit 7f220fa
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/pre-commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Install Python
run: uv python install
- name: Install dependencies
run: uv sync
run: uv sync --offline
- name: Set PY
id: set-py
run: echo "PY=$(python -VV | sha256sum | cut -d ' ' -f 1)" >> $GITHUB_OUTPUT
Expand All @@ -47,4 +47,4 @@ jobs:
- name: Run pre-commit
env:
PRE_COMMIT_COLOR: always
run: uv run pre-commit run --all-files
run: uv run --offline pre-commit run --all-files
10 changes: 5 additions & 5 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,20 +51,20 @@ jobs:
- name: Install Python
run: uv python install ${{ matrix.python-version }}
- name: Install dependencies
run: uv sync
run: uv sync --offline
- name: Run live tests (needing an internet connection)
run: uv run coverage run -m pytest -m live
run: uv run --offline coverage run -m pytest -m live
- name: Run offline tests
if: github.event_name != 'schedule'
run: uv run coverage run -am pytest -m "not live" --disable-network
run: uv run --offline coverage run -am pytest -m "not live" --disable-network --offline
- name: Report coverage
if: github.event_name != 'schedule'
run: uv run coverage report
run: uv run --offline coverage report
# The following step will be removed when all the project is covered with tests
- name: Maintain 100% coverage on tested modules
if: github.event_name != 'schedule'
run: |
uv run coverage report --fail-under 100 \
uv run --offline coverage report --fail-under 100 \
xil/_currencies.py \
xil/_headers.py \
xil/_df_normalizer.py \
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ dev-dependencies = [
"mypy>=1.11.2",
"pandas-stubs>=2.2.2.240807",
]
offline = true

[tool.ruff]
target-version = "py311"
Expand Down

0 comments on commit 7f220fa

Please sign in to comment.