Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore single digit removal when selection length is not equal to 1 #48

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Ignore single digit removal when selection length is not equal to 1 #48

merged 1 commit into from
Sep 17, 2018

Conversation

ddayguerrero
Copy link
Collaborator

@ddayguerrero ddayguerrero commented Sep 15, 2018 •
edited
Loading

Changes

Fixes #29

Why introduce these changes?

  • Improve user experience by allowing removal of longer digit selections with mouse and Crtl+A.

How is this achieved?

Given that a format is triggered by a Backspace/Delete (key code 8) key and that the selection length is not equal to 1, end function execution and ultimately ignore the following:

  • Removal of single digit + trailing space
  • Removal of single digit if input value ends in space + digit.

@jondavidjohn jondavidjohn merged commit d091dab into jondavidjohn:develop Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddayguerrero @jondavidjohn