Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some stylistic improvements #130

Merged
merged 2 commits into from
Nov 19, 2024
Merged

some stylistic improvements #130

merged 2 commits into from
Nov 19, 2024

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Nov 10, 2024 •
edited by jonhoo
Loading

This change is Reviewable

jonhoo
jonhoo approved these changes Nov 19, 2024
View reviewed changes
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love let-else :p Thanks!

@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.83%. Comparing base (d360837) to head (fab192e).
Report is 10 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
src/iter/traverser.rs 82.89% <ø> (ø)
src/map.rs 78.12% <100.00%> (-0.66%) ⬇️
src/node.rs 69.86% <100.00%> (-3.35%) ⬇️
src/raw/mod.rs 76.19% <ø> (-3.54%) ⬇️

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features:

@jonhoo jonhoo merged commit b6f21d8 into jonhoo:main Nov 19, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhoo jonhoo jonhoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ada4a @jonhoo