Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rand to [dev-dependencies] #27

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Move rand to [dev-dependencies] #27

merged 1 commit into from
Jan 24, 2020

Conversation

cuviper
Copy link
Collaborator

@cuviper cuviper commented Jan 24, 2020

It's only used in a few tests, not in the crate proper.

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #27 into master will decrease coverage by 0.45%.
The diff coverage is n/a.

Impacted Files Coverage Δ
src/map.rs 83.95% <0%> (-0.7%) ⬇️

@jonhoo
Copy link
Owner

jonhoo commented Jan 24, 2020

Good catch! I think there's an argument that num_cpus should also be moved behind a feature flag. We'd just have to figure out a sensible value to set stride to. That would also help with #26 where num_cpus isn't available.

@jonhoo jonhoo merged commit 73de927 into jonhoo:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants