Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

Remove global MatomoTracker from the window object #196

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Remove global MatomoTracker from the window object #196

merged 1 commit into from
Aug 3, 2020

Conversation

jonkoops
Copy link
Owner

@jonkoops jonkoops commented Aug 3, 2020

Closes #186

@jonkoops jonkoops added the enhancement New feature or request label Aug 3, 2020
@jonkoops jonkoops added this to the 0.2.0 milestone Aug 3, 2020
@jonkoops jonkoops requested a review from chrisvanmook August 3, 2020 15:31
@jonkoops jonkoops self-assigned this Aug 3, 2020
@jonkoops jonkoops merged commit bcd1967 into master Aug 3, 2020
@jonkoops jonkoops deleted the feature/no-window branch August 3, 2020 16:20
@piotr-cz piotr-cz mentioned this pull request Aug 3, 2020
Closed
@piotr-cz
Copy link
Contributor

piotr-cz commented Aug 3, 2020

I think the example script should be removed from package.json as well

@piotr-cz piotr-cz mentioned this pull request Aug 4, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisvanmook chrisvanmook chrisvanmook approved these changes

Assignees

@jonkoops jonkoops

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Global object (window) confusion
3 participants
@jonkoops @piotr-cz @chrisvanmook