Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

Fix required error #278

Closed
wants to merge 3 commits into from
Closed

Conversation

gky360
Copy link

@gky360 gky360 commented Sep 29, 2020

Fixes #277.

Amsterdam styled components pull request

Before opening a pull request, please ensure:

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)

@chrisvanmook chrisvanmook requested review from chrisvanmook and jonkoops and removed request for chrisvanmook October 1, 2020 07:47
@jonkoops
Copy link
Owner

jonkoops commented Oct 1, 2020

Hi @gky360. This is certainly a bug you have found. We're considering a new API design that will eliminate the need for passing a massive object with options and instead make individual calls to trigger these kind of options, see #176.

I think your change is logical, but it would conflict with the work done in #236 to make these options required. I would recommend to wait until we roll out our new API which will probably be done a couple of weeks from now when we have some time to work on it.

@gky360
Copy link
Author

gky360 commented Oct 1, 2020

Thank you for checking the PR. I understand your policy on the new API. I'm looking forward to the new API to be released.
I'm closing this PR now.

@gky360 gky360 closed this Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

urlBase and siteId is required even when disabled is true
2 participants