Skip to content

Commit

Permalink
Timestamp needs to be nullable. Comment out SourceLink PackageReferen…
Browse files Browse the repository at this point in the history
…ce to see if SourceLink still works.
  • Loading branch information
jonsagara committed Nov 19, 2023
1 parent f17663c commit d1099c6
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<LangVersion>12.0</LangVersion>

<!-- NuGet -->
<Version>2.0.6</Version>
<Version>2.0.7</Version>
<AssemblyVersion>2.0.0</AssemblyVersion>
<FileVersion>2.0.0</FileVersion>
<Authors>Jon Sagara</Authors>
Expand Down
2 changes: 1 addition & 1 deletion src/Sagara.Core.Data/Models/Entity.cs
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public abstract class Entity : IEntity
[Timestamp]
// Required by EF Core for SQL Server Timestamp functionality.
#pragma warning disable CA1819 // Properties should not return arrays
public byte[] Timestamp { get; set; } = null!;
public byte[]? Timestamp { get; set; }
#pragma warning restore CA1819 // Properties should not return arrays

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Sagara.Core.Data/Models/IEntity.cs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public interface IEntity
/// </summary>
// Justification: Required by EF Core for the SQL Server timestamp to function.
#pragma warning disable CA1819 // Properties should not return arrays
byte[] Timestamp { get; set; }
byte[]? Timestamp { get; set; }
#pragma warning restore CA1819 // Properties should not return arrays
}

4 changes: 2 additions & 2 deletions src/Sagara.Core/Sagara.Core.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@

<ItemGroup>
<PackageReference Include="Microsoft.IO.RecyclableMemoryStream" Version="2.3.2" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0">
<!--<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</PackageReference>-->
<PackageReference Include="NodaTime" Version="3.1.9" />
</ItemGroup>

Expand Down

0 comments on commit d1099c6

Please sign in to comment.