Allow NEW_PASSWORD_REQUIRED challenge completion. #22

ncb000gt · 2018-09-15T02:02:57Z

Cognito allows users to be created via an admin user. The new user gets
a temporary password and is expected to change that password via a
challenge response. This allows that flow by making use of some existing
code.

Signed-off-by: Nick Campbell [email protected]

Cognito allows users to be created via an admin user. The new user gets a temporary password and is expected to change that password via a challenge response. This allows that flow by making use of some existing code. Signed-off-by: Nick Campbell <[email protected]>

ncb000gt · 2018-09-17T14:23:46Z

As I looked through more of the code, it seemed like there may be other places that could use the common function than just the two for which I impl it. I can go through and make the others use that if you'd like before landing this pr. Let me know.

ncb000gt · 2018-10-15T16:20:50Z

Bump.

jonsaw · 2018-11-10T08:53:37Z

Thanks for the PR @ncb000gt. I'll try to find some time this week to look into this. Been super busy on my end here -- sorry for the late responses.

ncb000gt · 2018-11-10T14:56:34Z

No worries. I know how it feels running a few open source projects myself. ;D

Thanks!

FWIW- This code is running in my Flutter app.

Cognito allows users to be created via an admin user. The new user gets a temporary password and is expected to change that password via a challenge response. This allows that flow by making use of some existing code. Signed-off-by: Nick Campbell <[email protected]> jonsaw#22

aneeshjoshi · 2018-11-15T03:43:30Z

lib/src/cognito_user.dart

@@ -657,6 +657,18 @@ class CognitoUser {
    return data;
  }

+  Future<void> completeNewPasswordChallenge(String newPassword) async {


Any reason we don't want to pass back some status of whether the new password challenge was successful or failed?

I don't have any issue passing back the response personally. However, I understood this lib to use exceptions for flow control. So my thoughts were that if there was a problem that the client would except and that you'd have to appropriately deal with that.

Still, I don't have any reservations about responding with a good or bad signal to the caller. @jonsaw what are your thoughts on this?

aneeshjoshi · 2018-11-15T22:16:30Z

@ncb000gt Any chance you can provide a sample example of how to use this? I'm having some trouble where when I call completeNewPasswordChallenge, it's being invoked with a null cognito user and null session.

My current flow is:

Call Login with username and password
When it throws an exception that a new password is needed, I ask the user for a new password and call this function. However it seems when I do this the UserService doesn't have the necessary session/user information.

ncb000gt · 2018-11-15T22:36:28Z

@aneeshjoshi I'm using this library in Flutter so YMMV.

I'm using this inside my mobile app. I attempt to login. If that fails, an exception is thrown and I catch that with:

} on CognitoUserNewPasswordRequiredException catch (e) {
  message = 'It looks like this is your first time logging in. You need to specify a new password.';
  ...

Then I render the "new password" form. I've held onto the CognitoUser() object I used to attempt the login in the first place and call:

  myCognitoUser.completeNewPasswordChallenge("MY new PASSWORD!");

At this point I just require that the user login again.

I do think your point above is relevant, re: if the user doesn't enter the right password conforming to whatever specifications you've laid out...but again, I'd expect that an exception would be thrown. I should probably verify that part somewhere. ;D

Does that help?

aneeshjoshi · 2018-11-16T00:51:16Z

That does help. I'm new to flutter and this lib, so I need to figure out how to maintain access to the cognito user. I had trouble where each rebuild of the widget was resetting my user service and underlying objects. Not sure what the idiomatic dart/flutter way to deal with this is. For now I'm trying to keep a user service as a static instance on MyApp level widget.

…

On Thu, Nov 15, 2018 at 5:36 PM Nick Campbell ***@***.***> wrote: @aneeshjoshi <https://github.com/aneeshjoshi> I'm using this library in Flutter so YMMV. I'm using this inside my mobile app. I attempt to login. If that fails, an exception is thrown and I catch that with: } on CognitoUserNewPasswordRequiredException catch (e) { message = 'It looks like this is your first time logging in. You need to specify a new password.'; ... Then I render the "new password" form. I've held onto the CognitoUser() object I used to attempt the login in the first place and call: myCognitoUser.completeNewPasswordChallenge("MY new PASSWORD!"); At this point I just require that the user login again. I do think your point above is relevant, re: if the user doesn't enter the right password conforming to whatever specifications you've laid out...but again, I'd expect that an exception would be thrown. I should probably verify that part somewhere. ;D Does that help? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#22 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADEfayRg9u4rQiCPrAcpTg-a7yXULi4zks5uvexsgaJpZM4WqJYw> .

ncb000gt · 2018-11-16T02:21:03Z

@aneeshjoshi Yea. I'm not entirely sure of the idiomatic dart/flutter approach, but the way I handled it was put a "service" layer that is a singleton inside the app. That maintains the CognitoUser state across the application. Then I have "listeners" that are notified of changes to auth state which will then return the user to the login screen. I settled on this approach, but I believe you could end up doing something similar or better using the BLoC approach in flutter. I just never got a chance to do that. Once the app is built and functional I'm expecting to rework a lot of parts of it. :)

Cognito allows users to be created via an admin user. The new user gets a temporary password and is expected to change that password via a challenge response. This allows that flow by making use of some existing code. Signed-off-by: Nick Campbell <[email protected]> jonsaw#22

logins like Google or Facebook.

…s/amazon-cognito-identity-dart into new_password_required_challenge

Cognito allows users to be created via an admin user. The new user gets a temporary password and is expected to change that password via a challenge response. This allows that flow by making use of some existing code. Signed-off-by: Nick Campbell <[email protected]> jonsaw#22

ncb000gt · 2019-03-28T01:51:58Z

This PR is no longer "clean" since I inadvertently pushed changes up to my branch that @BerndWessels made to one of his PRs...I can recreate the original pr if you really want.

tigrenok00 · 2019-05-13T06:02:15Z

@ncb000gt @jonsaw
Hi guys, is this going to be available? We have the same scenario...

ncb000gt · 2019-05-31T05:08:07Z

@jonsaw ping.

sumeet07 · 2019-10-09T21:15:10Z

Hello there, Changes look safe. Can we merge this to master?

grahamsmart · 2019-11-18T05:11:00Z

@jonsaw any chance of this being merged into master?

furaiev · 2019-12-23T06:16:57Z

Hi all here,
I've copied this project in a separate package (because this one isn't supported anymore) https://pub.dev/packages/amazon_cognito_identity_dart_2
There are already fixes that were required by my project and NEW_PASSWORD_REQUIRED from maciejkozuch.
Pls take a look at latest PR furaiev/amazon-cognito-identity-dart-2#2 and welcome to contribute

ncb000gt · 2020-01-19T21:43:42Z

I know a bunch of people have commented here. I've just implemented and tested amazon_cognito_identity_dart_2 in my project and it's working largely as expected for my use case with this feature. The only gotcha is that the function name is different from the one I specified, it is sendNewPasswordRequiredAnswer.

Hope that helps anyone here who is still struggling with this and thanks to @jonsaw for all the initial work on this project. It was really helpful. Thanks to @furaiev for picking it up for the next phase.

Merge branch 'http12' into new_password_required_challenge

fa0f33c

aneeshjoshi reviewed Nov 15, 2018

View reviewed changes

BerndWessels and others added 2 commits February 28, 2019 14:24

Added optional authenticator parameter which enables us to use social

8a0eea8

logins like Google or Facebook.

Merge branch 'enable-social-logins' of https://github.com/BerndWessel…

6c15d5b

…s/amazon-cognito-identity-dart into new_password_required_challenge

ncb000gt mentioned this pull request Mar 13, 2019

How to handle New Password challenge? #34

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow NEW_PASSWORD_REQUIRED challenge completion. #22

Allow NEW_PASSWORD_REQUIRED challenge completion. #22

ncb000gt commented Sep 15, 2018

ncb000gt commented Sep 17, 2018

ncb000gt commented Oct 15, 2018

jonsaw commented Nov 10, 2018

ncb000gt commented Nov 10, 2018 •

edited

Loading

aneeshjoshi Nov 15, 2018

ncb000gt Nov 15, 2018

aneeshjoshi commented Nov 15, 2018

ncb000gt commented Nov 15, 2018

aneeshjoshi commented Nov 16, 2018 via email

ncb000gt commented Nov 16, 2018

ncb000gt commented Mar 28, 2019

tigrenok00 commented May 13, 2019

ncb000gt commented May 31, 2019

sumeet07 commented Oct 9, 2019

grahamsmart commented Nov 18, 2019

furaiev commented Dec 23, 2019

ncb000gt commented Jan 19, 2020

Allow NEW_PASSWORD_REQUIRED challenge completion. #22

Are you sure you want to change the base?

Allow NEW_PASSWORD_REQUIRED challenge completion. #22

Conversation

ncb000gt commented Sep 15, 2018

ncb000gt commented Sep 17, 2018

ncb000gt commented Oct 15, 2018

jonsaw commented Nov 10, 2018

ncb000gt commented Nov 10, 2018 • edited Loading

aneeshjoshi Nov 15, 2018

Choose a reason for hiding this comment

ncb000gt Nov 15, 2018

Choose a reason for hiding this comment

aneeshjoshi commented Nov 15, 2018

ncb000gt commented Nov 15, 2018

aneeshjoshi commented Nov 16, 2018 via email

ncb000gt commented Nov 16, 2018

ncb000gt commented Mar 28, 2019

tigrenok00 commented May 13, 2019

ncb000gt commented May 31, 2019

sumeet07 commented Oct 9, 2019

grahamsmart commented Nov 18, 2019

furaiev commented Dec 23, 2019

ncb000gt commented Jan 19, 2020

ncb000gt commented Nov 10, 2018 •

edited

Loading