Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate params entry and move this to the right place #15464

Merged
merged 2 commits into from
May 22, 2017

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Apr 21, 2017

Pull Request for Issue #15212

Summary of Changes

Shows the hits for com_newsfeeds

Testing Instructions

Go to the setting of a neewsfeed, see the hits are now showed

Expected result

Hits are showed

Actual result

hits are not showed

Documentation Changes Required

none.

Additional info

I have not found yet a way how to fill that field with a value.

For me it looks like a did never work or copy and paste error from weblinks as also the description language key is from weblinks. This also needs to be fixed if needed at all.

I would vote for removal that from the GUI as it was nerver displayed in isis nor does it make sense nor does it work.

@Quy
Copy link
Contributor

Quy commented Apr 21, 2017

Sorry I highlighted its location in the wrong place. Here it is in the Weblinks plugin:
weblinks

@brianteeman
Copy link
Contributor

For me it looks like a did never work or copy and paste error from weblinks as also the description language key is from weblinks. This also needs to be fixed if needed at all.

see #15201 which i did some time ago

@zero-24
Copy link
Contributor Author

zero-24 commented Apr 21, 2017

Thanks. So i don't need to take care about that here. If we decide to keep that field in.

@joomla-cms-bot joomla-cms-bot changed the title Remove dublicate params entry and move htis to the rights place Remove dublicate params entry and move this to the rights place Apr 22, 2017
@ghost
Copy link

ghost commented Apr 22, 2017

@zero-24 so com_newsfeed is to test, not weblinks?

@brianteeman brianteeman changed the title Remove dublicate params entry and move this to the rights place Remove duplicate params entry and move this to the right place Apr 22, 2017
@zero-24
Copy link
Contributor Author

zero-24 commented Apr 22, 2017

Correct.

@ghost
Copy link

ghost commented Apr 22, 2017

"Hits" are shown, but Tooltip is about "Weblinks":
bildschirmfoto 2017-04-22 um 11 33 13

@zero-24
Copy link
Contributor Author

zero-24 commented Apr 22, 2017

Correct this is fixed by the PR brian linked above.

@ghost
Copy link

ghost commented Apr 22, 2017

I have tested this item ✅ successfully on 323c7e9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15464.

@ghost
Copy link

ghost commented Apr 22, 2017

Why is "PR-staging" removed if i set "Easy Test" on "Yes"?

@zero-24
Copy link
Contributor Author

zero-24 commented Apr 22, 2017

Looks like there are hickups. Can you dokument the exact issue number + the exact steps you took as issue to the issue trackers issue tracker. ;)

@ghost
Copy link

ghost commented Apr 22, 2017

done: joomla/jissues#962

@zero-24
Copy link
Contributor Author

zero-24 commented Apr 22, 2017

👍

@sanderpotjer
Copy link
Member

I have tested this item ✅ successfully on 323c7e9

The PR does indeed display the field, but without a value.

So while the test is successful, I would recommend to either fix the display of the hits value too or remove the display of this hits field completely.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15464.

@ghost
Copy link

ghost commented May 1, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 1, 2017
@rdeutz rdeutz added this to the Joomla 3.7.2 milestone May 4, 2017
@rdeutz rdeutz modified the milestones: Joomla 3.7.2, Joomla 3.7.3 May 18, 2017
@rdeutz rdeutz removed this from the Joomla 3.7.2 milestone May 18, 2017
@rdeutz
Copy link
Contributor

rdeutz commented May 22, 2017

@zero-24 please check the conflicts

@rdeutz rdeutz merged commit 96963e0 into joomla:staging May 22, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 22, 2017
@zero-24 zero-24 deleted the com_neewsfeeds branch May 23, 2017 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants