-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate params entry and move this to the right place #15464
Conversation
see #15201 which i did some time ago |
Thanks. So i don't need to take care about that here. If we decide to keep that field in. |
@zero-24 so com_newsfeed is to test, not weblinks? |
Correct. |
Correct this is fixed by the PR brian linked above. |
I have tested this item ✅ successfully on 323c7e9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15464. |
Why is "PR-staging" removed if i set "Easy Test" on "Yes"? |
Looks like there are hickups. Can you dokument the exact issue number + the exact steps you took as issue to the issue trackers issue tracker. ;) |
done: joomla/jissues#962 |
👍 |
I have tested this item ✅ successfully on 323c7e9 So while the test is successful, I would recommend to either fix the display of the hits value too or remove the display of this hits field completely. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15464. |
RTC after two successful tests. |
@zero-24 please check the conflicts |
Pull Request for Issue #15212
Summary of Changes
Shows the hits for com_newsfeeds
Testing Instructions
Go to the setting of a neewsfeed, see the hits are now showed
Expected result
Hits are showed
Actual result
hits are not showed
Documentation Changes Required
none.
Additional info
I have not found yet a way how to fill that field with a value.
For me it looks like a
did never work
orcopy and paste error
from weblinks as also the description language key is from weblinks. This also needs to be fixed if needed at all.I would vote for removal that from the GUI as it was nerver displayed in isis nor does it make sense nor does it work.