Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] Remove the empty indexer files #44646

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Dec 20, 2024

Summary of Changes

Remove the empty indexer files as they are there only for old include code. They do not have any logic.

Code review.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: Remove the empty indexer files Manual#349

  • No documentation changes for manual.joomla.org needed

@laoneo laoneo added the b/c break This item changes the behavior in an incompatible why. HEADS UP label Dec 20, 2024
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on ad1241a

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44646.

@richard67
Copy link
Member

I have tested this item ✅ successfully on ad1241a

Code review: The removed files only contain a \defined('_JEXEC') or die; and a doc block with a deprecation comment.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44646.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44646.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 21, 2024
@Bodge-IT Bodge-IT merged commit 0f622c9 into joomla:6.0-dev Jan 8, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 8, 2025
@Bodge-IT Bodge-IT added this to the Joomla! 6.0.0 milestone Jan 8, 2025
@laoneo laoneo deleted the finder/indexer branch January 9, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b/c break This item changes the behavior in an incompatible why. HEADS UP PR-6.0-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants