Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Remove Cassiopeia color overrides #44661

Open
wants to merge 1 commit into
base: 5.3-dev
Choose a base branch
from

Conversation

brianteeman
Copy link
Contributor

Summary of Changes

Remove the extra color related css from cassiopeia as they are not needed

See #39379 (comment)

As far as I can tell these extra lines are not needed at all with BS 5.3

Testing Instructions

Create an article with the following

<p><span class="text text-secondary">text-secondary</span> <span class="text text-primary">text-primary</span> <span class="text text-info">text-info</span> <span class="text text-success">text-success</span> <span class="text text-warning">text-warning</span> <span class="text text-danger">text-danger</span></p>
<p class="h1">Example heading <span class="badge bg-primary">bg-primary</span></p>
<p class="h2">Example heading <span class="badge bg-secondary">bg-secondary</span></p>
<p class="h3">Example heading <span class="badge bg-success">bg-success</span></p>
<p class="h4">Example heading <span class="badge bg-danger">bg-danger</span></p>
<p class="h5">Example heading <span class="badge bg-warning">bg-warning</span></p>
<p class="h6">Example heading <span class="badge bg-dark">bg-dark</span></p>

as it is an scss change either use a prebuilt package or npm run build:css

Actual result BEFORE and AFTER applying this Pull Request

image

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev labels Dec 23, 2024
@fgsw
Copy link

fgsw commented Dec 23, 2024

I have tested this item ✅ successfully on 3d5593c

Before After
44661-stable 44661-pr

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44661.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 3d5593c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44661.

@alikon
Copy link
Contributor

alikon commented Dec 29, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44661.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants