Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3][cypress] test console command site:up & site:down #44683

Open
wants to merge 2 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Jan 3, 2025

Summary of Changes

add test for console command


- php cli/joomla site:up
- php cli/joomla site:down

Testing Instructions

npm cypress run --spec tests/System/integration/cli/SiteUpDown.cy.js

Actual result BEFORE applying this Pull Request

N/A

Expected result AFTER applying this Pull Request

conole command tested

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@muhme
Copy link
Contributor

muhme commented Jan 4, 2025

From my perspective, testing the Joomla command-line tool client within Joomla System Tests is not ideal. This approach reintroduces a dependency that was intentionally removed by #44656 for valid reasons. Are Joomla System Tests not exclusively meant for testing the website frontend and backend? Could we consider having separate tests dedicated to the command-line tool instead?

@alikon
Copy link
Contributor Author

alikon commented Jan 4, 2025

Are Joomla System Tests not exclusively meant for testing the website frontend and backend?

i dont think so, in joomla we have something like 4 applications:

  • frontend
  • backend
  • websrvices
  • cli

so i consider a good pratice to test all of them with the same toolchian

@alikon alikon changed the title site-up-&-down [5.3][cypress] test console command site:up & site:down Jan 4, 2025
@alikon alikon marked this pull request as ready for review January 4, 2025 08:46
@laoneo laoneo self-assigned this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants