Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should-be-enough-even-for-edge-case #44856

Open
wants to merge 3 commits into
base: 5.3-dev
Choose a base branch
from
Open

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Feb 11, 2025

Pull Request for Issue #42376 , #38835 .
redo of #42765 for sql custom field

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev labels Feb 11, 2025
@alikon
Copy link
Contributor Author

alikon commented Feb 11, 2025

follow-up to #44794

@alikon alikon marked this pull request as ready for review February 11, 2025 12:22
@Fedik Fedik added the Feature label Feb 11, 2025
@Fedik
Copy link
Member

Fedik commented Feb 11, 2025

Yea, that can work

@joomdonation
Copy link
Contributor

I think we should not set the default value to that high number. Not my field, so I asked Chat GTP and it gives good explanation for what I think about:

Performance Issues – If the dropdown contains a large dataset, displaying too many results can slow down rendering and affect user experience.
UI Clutter – Too many search results can make the dropdown overwhelming and difficult to navigate.

Strange that it also recommends use 10 for the parameters (maybe it already read our code :D).

If users cannot find the items they are looking for, they need to enter a more accurate keyword for searching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants