Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Restrict bootstrap collapse to the header #44858

Open
wants to merge 2 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Feb 11, 2025

Pull Request for Issue #44853 .

Summary of Changes

Restrict the js for collapsing accordions etc to relevant elements in the header

Steps to reproduce the issue

in a back-end view ./administrator/components/com_content/tmpl/articles/default.php create an accordion with the joomla core htmlhelpers, add the following lines before the line starting with <form action=

<?php echo HTMLHelper::_('bootstrap.startAccordion', 'accordion-test'); ?>
<?php echo HTMLHelper::_('bootstrap.addSlide', 'accordion-test', Text::_('TEST'), 'test-collapse', 'test'); ?>
   <h1>TEST-ACCORDION</h1>
<?php echo HTMLHelper::_('bootstrap.endSlide'); ?>
<?php echo HTMLHelper::_('bootstrap.endAccordion'); ?>

When you now go to the view articles, you see the closed accordion.
Click on the accordion to open it.
The accordion opens.

now click on the topbar menu 'User Menu'

The accordion now closes although it should stay open.

Actual result BEFORE applying this Pull Request

The article accordion collapses when opening the user menu or tourguide dropdown

Expected result AFTER applying this Pull Request

The article accordion remains open when opening the user menu or tourguide dropdown

Testing

As this is a js change you will need to either run npm i or use a prebuilt package

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev labels Feb 11, 2025
Signed-off-by: BrianTeeman <[email protected]>
@Ruud68
Copy link
Contributor

Ruud68 commented Feb 11, 2025

I have tested this item ✅ successfully on 101cefc

Works! Thanks @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44858.

@ceford
Copy link
Contributor

ceford commented Feb 12, 2025

I have tested this item ✅ successfully on 101cefc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44858.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44858.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants