Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Remove the reference to the super global #44867

Open
wants to merge 4 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Feb 12, 2025

Summary of Changes

As we move in version 6 to the framework package, the deprecated cookie class should not reference the $_COOKIE superglobal directly with the internal data holder. This makes the transition easier as the framework doesn't use it as well by reference.

Testing Instructions

Log in on the front end with the remember me flag.

Actual result BEFORE applying this Pull Request

It works.

Expected result AFTER applying this Pull Request

It still works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@QuyTon
Copy link
Contributor

QuyTon commented Feb 13, 2025

I have tested this item ✅ successfully on ed9f341


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44867.

@fgsw
Copy link

fgsw commented Feb 13, 2025

I have tested this item ✅ successfully on ed9f341

Test by using the prebuilt Package via custom update server.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44867.

@QuyTon
Copy link
Contributor

QuyTon commented Feb 13, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44867.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-5.3-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants