[5.2] Fix incorrect error message when failing to rename a file due to an existing destination. #45149
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #45087,
Summary of Changes:
Testing Instructions
Navigate to the file manager in Joomla where renaming files is possible. (Refer how to reproduce at #45087)
Actual result BEFORE applying this Pull Request
The error messages may appear incorrectly or out of order, causing confusion:
1."Error renaming item." (Correct but unclear without context)
2. "Move file is not possible as destination already exists." (Sometimes redundant or misleading)
Expected result AFTER applying this Pull Request
1st : Error renaming item: Please choose a file name with a-z, A-Z, 0-9, ., - and _.(Avoid Special Characters also name should
not start or end with a period )
2nd : Action not Possible as a file with this name already Exists
clearly indicate why the operation failed.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed