Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Fix Light Mode Visibility for Table Headers in User Profile #45188

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

Hemang360
Copy link

Pull Request for Issue #44248.

Summary of Changes

  • Fixed an issue where the "Name" and "Actions" table headers in the user profile section were not visible in Light Mode.

  • Updated _com_users.scss to apply a contrasting text color (var(--bs-body-color)) to ensure visibility.

Testing Instructions

  • Switch to Light Mode in Joomla Administrator.

  • Navigate to Users > Manage > Edit User Profile.

  • Check if the "Name" and "Actions" table headers are visible and readable.

Actual result BEFORE applying this Pull Request

Screenshot 2025-03-23 003303

The "Name" and "Actions" headers had the same color as the background, making them invisible in Light Mode.

Expected result AFTER applying this Pull Request

Screenshot 2025-03-23 003443

The "Name" and "Actions" headers are now clearly visible with sufficient contrast against the background.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev labels Mar 22, 2025
@fgsw
Copy link

fgsw commented Mar 23, 2025

I have tested this item ✅ successfully on 6a85463


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45188.

1 similar comment
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 6a85463


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45188.

@alikon
Copy link
Contributor

alikon commented Mar 23, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45188.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 23, 2025
@laoneo laoneo merged commit c8b3f3c into joomla:5.3-dev Mar 24, 2025
4 checks passed
@laoneo
Copy link
Member

laoneo commented Mar 24, 2025

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 24, 2025
@laoneo laoneo added this to the Joomla! 5.3.0 milestone Mar 24, 2025
@Hemang360
Copy link
Author

Happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants