Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ordering field mismatch in frontend modal and filter fields are now identical. #45189

Closed
wants to merge 1 commit into from

Conversation

Rohit-rk07
Copy link

Pull Request for Issue #37841 .

Summary of Changes

Fixed the ordering field in the frontend modal to match the list.(id Descending)

Ensured frontend and backend filter fields are identical.(added featured)

Testing Instructions

Open the frontend modal.

Check if the ordering field matches the list.

Verify that filter fields in the frontend and backend are identical.

Ensure all filter fields look the same in the frontend.

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

Screenshot (72)

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.2-dev labels Mar 22, 2025
@fgsw
Copy link

fgsw commented Mar 23, 2025

@Rohit-rk07 The pull request #45106 solves also issue 1 of report #37841 and is set to "Ready to Commit" (see #37841 (comment)).

There are open questions about issues 2 and 3 (#37841 (comment)) waiting for an answer by @heelc29.

@Rohit-rk07
Copy link
Author

Rohit-rk07 commented Mar 23, 2025

@fgsw Ok.But i have also tried to solve issue 2 by adding featured drop down and identical arrangements in filter fields in frontend.

About issue 3 i think the spacing needs to be same in frontend amd backend. I am working on that.

@fgsw
Copy link

fgsw commented Mar 23, 2025

@Rohit-rk07 All fine, it was just an information.

It's difficult to get an overview having an report about 3 issues, 2 pull request solving 1 or more issues and open questions without an answer by issue-opener.

@Rohit-rk07
Copy link
Author

@fgsw Yeah. We will wait then . Thanks for your response 👍

@Dileepadari
Copy link

@Rohit-rk07 Your PR doesn't account for workflows - there is a filter for workflows in the backend. I have included it in PR #45206.

@Rohit-rk07
Copy link
Author

why stage filter is not visible in backend

@Rohit-rk07 Rohit-rk07 closed this Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants