gcassert: allow absolute paths to be used for packages, and add cwd arg #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickystewart
force-pushed
the
gcassert-abs-path
branch
from
bd0d1de
to
e55e392
Compare
yuzefovich
approved these changes
Feb 24, 2024
|
@rickystewart looks like the build failed |
|
Looks reasonable, though I don't love that it breaks the API for current users. How about a CWD-passing variant? Also, could you please add an absolute path test and an explicit CWD test? |
rickystewart
force-pushed
the
gcassert-abs-path
branch
from
e55e392
to
36a0eb5
Compare
|
@jordanlewis Have a look. Also fixed the test. |
rickystewart
force-pushed
the
gcassert-abs-path
branch
from
36a0eb5
to
55a956e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.