Skip to content

Commit

Permalink
updated BL3P fees, updated changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
jorijn committed Aug 13, 2021
1 parent d4902f3 commit a95c587
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
## [v1.5.1] - 2021-08-13
### Changed
* BL3P changed their withdrawal fee from 30k sat to 5k sat. This change updates to code to display the correct fee.

## [v1.5.0] - 2021-07-10
### Added
* When you buy Bitcoin and supply `EXPORT_CSV=/location/to/file.csv`, Bitcoin-DCA will export the order information to that file in CSV format.
Expand Down Expand Up @@ -90,7 +94,8 @@ Due to regulatory changes in The Netherlands, BL3P and Bitvavo currently require
### Added
* A Python based fallback mechanism for 32bits systems. Unfortunately a bug prevented Raspberry Pi users from using Xpubs properly. The system will automatically use the native, more advanced method or derivation for systems that are capable and degrade to the Python tool without people noticing.

[Unreleased]: https://github.com/Jorijn/bitcoin-dca/compare/v1.5.0...HEAD
[Unreleased]: https://github.com/Jorijn/bitcoin-dca/compare/v1.5.1...HEAD
[v1.5.1]: https://github.com/Jorijn/bitcoin-dca/compare/v1.5.0...v1.5.1
[v1.5.0]: https://github.com/Jorijn/bitcoin-dca/compare/v1.4.1...v1.5.0
[v1.4.1]: https://github.com/Jorijn/bitcoin-dca/compare/v1.4.0...v1.4.1
[v1.4.0]: https://github.com/Jorijn/bitcoin-dca/compare/v1.3.2...v1.4.0
Expand Down
2 changes: 1 addition & 1 deletion src/Service/Bl3p/Bl3pWithdrawService.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public function getAvailableBalance(): int

public function getWithdrawFeeInSatoshis(): int
{
return 30000;
return 5000;
}

public function supportsExchange(string $exchange): bool
Expand Down
2 changes: 1 addition & 1 deletion tests/Service/Bl3p/Bl3pWithdrawServiceTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ public function testSupportsExchange(): void
*/
public function testFeeCalculation(): void
{
static::assertSame(30000, $this->service->getWithdrawFeeInSatoshis());
static::assertSame(5000, $this->service->getWithdrawFeeInSatoshis());
}

private function createBalanceStructure(int $balance): array
Expand Down

0 comments on commit a95c587

Please sign in to comment.