Be more pedantic about file opens.

jorisvink · Feb 2, 2025 · b5a7a63 · b5a7a63
1 parent 7c81641
commit b5a7a63
Showing 1 changed file with 15 additions and 0 deletions.
diff --git a/src/utils.c b/src/utils.c
@@ -399,6 +399,7 @@ int
 sanctum_file_open(const char *path)
 {
 	int		fd;
+	struct stat	st;
 
 	PRECOND(path != NULL);
 
@@ -408,6 +409,20 @@ sanctum_file_open(const char *path)
 		return (-1);
 	}
 
+	if (fstat(fd, &st) == -1) {
+		sanctum_log(LOG_NOTICE,
+		    "failed to fstat '%s': %s", path, errno_s);
+		(void)close(fd);
+		return (-1);
+	}
+
+	if (!S_ISREG(st.st_mode)) {
+		sanctum_log(LOG_NOTICE,
+		    "'%s': not a regular file", path);
+		(void)close(fd);
+		return (-1);
+	}
+
 	return (fd);
 }