A few bugfixes #18
Merged
A few bugfixes #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change prevents img2pdf from opening *all* input files at once, which means it now works with thousands of input files.
Instead of crashing on an unrecognized colorspace, we now do
imgdata.convert('RGB').
|
This should theoretically address #6. |
|
Hi, Instead of writing |
|
The file does get closed at the end of the loop: https://github.com/DarwinAwardWinner/img2pdf/blob/master/src/img2pdf.py#L289 I wrote it this way to minimize the diff. But I can rewrite it using |
|
Indeed it did get closed! Nevertheless, I like the "with" option more even if it makes the diff ugly :) |
josch
added a commit
that referenced
this pull request
Nov 6, 2014
Avoid leaking file descriptors and convert unrecognized colorspaces to RGB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits allow img2pdf to work on thousands of files without running out of file descriptiors, and allow it to work on unexpected colorspaces by just converting the image data to RGB. I don't know much about colorspaces or PIL, so this is probably suboptimal, but it seems to work.