Skip to content

Commit

Permalink
osd/PrimaryLogPG.cc: CEPH_OSD_OP_OMAPRMKEYRANGE should mark omap dirty
Browse files Browse the repository at this point in the history
We should mark_omap_dirty() for all omap write ops, just like we did
in cb92792.

Currently, for CEPH_OSD_OP_OMAPRMKEYRANGE ops, clean_omap gets set to true,
which results in incomplete recovery of objects and results in
inconsistent PGs after a scrub.

Fixes: https://tracker.ceph.com/issues/54592
Signed-off-by: Neha Ojha <[email protected]>
  • Loading branch information
neha-ojha authored and joscollin committed Mar 29, 2022
1 parent 51a71e7 commit 3805fa4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/osd/PrimaryLogPG.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7979,6 +7979,7 @@ int PrimaryLogPG::do_osd_ops(OpContext *ctx, vector<OSDOp>& ops)
goto fail;
}
t->omap_rmkeyrange(soid, key_begin, key_end);
ctx->clean_regions.mark_omap_dirty();
ctx->delta_stats.num_wr++;
}
obs.oi.clear_omap_digest();
Expand Down

0 comments on commit 3805fa4

Please sign in to comment.