Only check comboboxTarget for validity

josefarias · Mar 7, 2024 · 331e877 · 331e877
1 parent a116528
commit 331e877
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/app/assets/javascripts/hw_combobox/models/combobox/validity.js b/app/assets/javascripts/hw_combobox/models/combobox/validity.js
@@ -31,8 +31,10 @@ Combobox.Validity = Base => class extends Base {
     return !this._valueIsInvalid
   }
 
+  // +_valueIsInvalid+ only checks if `comboboxTarget` (and not `_actingCombobox`) is required
+  // because the `required` attribute is only forwarded to the `comboboxTarget` element
   get _valueIsInvalid() {
-    const isRequiredAndEmpty = this._actingCombobox.required && !this.hiddenFieldTarget.value
+    const isRequiredAndEmpty = this.comboboxTarget.required && !this.hiddenFieldTarget.value
     return isRequiredAndEmpty
   }
 }