Add background color to group label #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a background color to `.hw-combobox__group__label` following `.hw-combobox__option` style.
|
Great catch! Thanks! I think it might be enough to have the bg color on the options and group labels themselves. Could've probably done it at the listbox level, too. But I don't think we need to do both. Anyway, food for thought for a possible simplification. I see no reason not to merge this for now though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a background color to
.hw-combobox__group__labelfollowing.hw-combobox__optionstyle.I wonder if it's worth adding the background color to
.hw-combobox__listboxlike Bootstrap does.https://github.com/twbs/bootstrap/blob/v5.3.3/scss/_dropdown.scss#L59