Decouple opening from focusing #235
Conversation
| @@ -124,11 +124,9 @@ This gem follows the [APG combobox pattern guidelines](https://www.w3.org/WAI/AR | |||
|
|
|||
| These are the exceptions: | |||
|
|
|||
| 1. Users cannot manipulate the combobox while it's closed. As long as the combobox is focused, the listbox is shown. | |||
| 2. The escape key closes the listbox and blurs the combobox. It does not clear the combobox. | |||
There was a problem hiding this comment.
Should add a test for this before merging.
There was a problem hiding this comment.
Here's the corresponding example: https://www.w3.org/WAI/ARIA/apg/patterns/combobox/examples/combobox-autocomplete-both/
Pressing esc once will close the listbox, and keep the autocompleted portion highlighted.
Pressing it again will clear the combobox.
Pressing enter will similarly keep the autocompleted portion highlighted — I don't think we do that currently. Consider addressing in a separate PR. Thought about addressing here but that's also breaking so probably good to call attention to it in its own PR/changelog entry.
Note that the "enter" behavior described above does not apply after navigating the listbox options with the arrow keys.
@brunoprietog let me know this would improve accessibility.
It also conveniently fixes a flaky test which would sometimes fail when something would focus (and open) the combobox right as we're asserting that it's closed (see diff where I'm removing a
sleepcall — which did little to fix the flakiness).