Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Riedel SimplyLive as source #717

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

KSauter
Copy link
Contributor

@KSauter KSauter commented Aug 20, 2024

Add Riedel SimplyLive as source.

Uses TSL UDP v5 internally.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there KSauter 👋

Thank you for opening your first PR for the Tally Arbiter project!

We will review it soon!

TallyArbiter fosters an open and welcoming environment for all our contributors. Please adhere to our Code Of Conduct.

@KSauter
Copy link
Contributor Author

KSauter commented Aug 20, 2024

Draft, because i still need to test it with with the SimplyLive server. Will do that in the next 1 or 2 days and update this PR accordingly.

@KSauter
Copy link
Contributor Author

KSauter commented Aug 20, 2024

Tested with server, can confirm it works. Remove draft state, ready to merge from my side

@KSauter KSauter marked this pull request as ready for review August 20, 2024 21:03
@josephdadams
Copy link
Owner

I'm ok with this even though it at first glance looks like it is just a copy of the TSL 5 UDP source type. I'm assuming you generated a unique UUID for the source type (I didn't check) :)

It would probably be a good idea to add to the docs that it is UDP in case the user does not know that and has a broader network configuration going on where UDP may not cross as intended.

@KSauter
Copy link
Contributor Author

KSauter commented Aug 21, 2024

Hi @josephdadams , thanks for your quick reply!
UUID i did generate a new one. Good hint with the UDP network, added it to the docs.

The main difference between this and plain TLS v5 UDP is the rule used to determine whether an address is visible on the pgm/prv or not.
The default TSL source uses text tally state (see TSL doc page 7) which does not specify anything about the tally text. The tally arbiter implementation assumes 0 => off / 1 => pgm / 2 => prv / 3 => both.
In case of simplylive, they only send 0 => off / 1 => in any pgm or prv or both.
The LH and RH tally state is correct (0 => off / non-0 => active with a color). Thats specified in the TSL doc, if a tally should be illuminated or not.

I added it to the TSL source first, including three new options:

  1. mode - should color or text be used?
  2. RH tally mapping - if in color mode, is RH tally pgm or prv?
  3. LH tally mapping - if in color mode, is LH tally pgm or prv?
    (right and left might differ on different mixers, as some of them have pgm on the right and others on the left)

I thought it would be easier for the user to have a dedicated SimplyLive source. But I can add back the different options in the TSL source if you like.

@josephdadams
Copy link
Owner

Can we have both? Make it easier for the simply live users and have the flexibility for the others?

@KSauter
Copy link
Contributor Author

KSauter commented Aug 21, 2024

Sure thing. I will make a new branch with the adjustments, based on this one.

@josephdadams josephdadams merged commit d8b62f0 into josephdadams:master Aug 21, 2024
6 checks passed
@KSauter KSauter deleted the add-simplylive branch August 21, 2024 14:54
@KSauter
Copy link
Contributor Author

KSauter commented Sep 5, 2024

Hi @josephdadams

just a quick heads up here. I didn't forget about the generic TSL v5 settings, just had too much on my plate to get my production with SimplyLive up and running.
Will implement it soon.

Best,
Kevin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants