-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Riedel SimplyLive as source #717
Conversation
(cherry picked from commit 72a3831)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there KSauter 👋
Thank you for opening your first PR for the Tally Arbiter project!
We will review it soon!
TallyArbiter fosters an open and welcoming environment for all our contributors. Please adhere to our Code Of Conduct.
Draft, because i still need to test it with with the SimplyLive server. Will do that in the next 1 or 2 days and update this PR accordingly. |
Tested with server, can confirm it works. Remove draft state, ready to merge from my side |
I'm ok with this even though it at first glance looks like it is just a copy of the TSL 5 UDP source type. I'm assuming you generated a unique UUID for the source type (I didn't check) :) It would probably be a good idea to add to the docs that it is UDP in case the user does not know that and has a broader network configuration going on where UDP may not cross as intended. |
Hi @josephdadams , thanks for your quick reply! The main difference between this and plain TLS v5 UDP is the rule used to determine whether an address is visible on the pgm/prv or not. I added it to the TSL source first, including three new options:
I thought it would be easier for the user to have a dedicated SimplyLive source. But I can add back the different options in the TSL source if you like. |
Can we have both? Make it easier for the simply live users and have the flexibility for the others? |
Sure thing. I will make a new branch with the adjustments, based on this one. |
just a quick heads up here. I didn't forget about the generic TSL v5 settings, just had too much on my plate to get my production with SimplyLive up and running. Best, |
Add Riedel SimplyLive as source.
Uses TSL UDP v5 internally.