-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional rwalk proposals #366
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 2173142774
💛 - Coveralls |
Thanks for the PR. In my opinion I would prefer to start merging just the ensenble sampling part and leave outside the axis based proposals and chi-proposals (unless there is a clear demonstrable benefit). For the ensemble sampling part, it seems that there is an easy to write example of a multimodal distribution where it'd be beneficial. I think it'd be good to put that example here, so we can assess the improvement/test that it perfoms like it should. (IMO the test suite is mostly checking that things can run and are not outright broken, rather testing the efficiency) |
I have spent some time looking and thinking about this proposal, and my current thinking (on top of what I said previously) is that
We would need some kind of interface for those samplers. As far I can see the classes defined here as far as I can see that would allow us more clearly add new samplers (and have them implemented externally even), and avoid adding more options for NestedSampler. Thoughts ? |
This PR adds a bunch of different methods for proposing points with the
rwalk
sampling.These are a combination of different scale distributions for the existing method and ensemble moves.
Some of the unit tests are failing, I still need to dig into that.
cc @joshspeagle @segasai