Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

Add ZWJ to emojis that need it #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

decklin
Copy link

@decklin decklin commented May 8, 2016

Some emojis that are made up of multiple code points require one or more zero-width joiners to be displayed correctly. Others, like flags, do not. I would find this data a lot more useful if the ZWJs were included so that I didn't have to know which was which.

@decklin
Copy link
Author

decklin commented May 8, 2016

The kiss/couple emojis here also require a U+FE0F (variation selector); forgot to mention that. This adds those as well.

@mikebe11
Copy link
Contributor

mikebe11 commented May 8, 2016

We're aware of the ZWJ's in code points but in putting those lists together that detail just slipped my mind. That oversight was my fault. Thanks for catching that and taking the time to fix it.
I'm not approving PR's here but I think what you've submitted is worth adding. 👍

@decklin
Copy link
Author

decklin commented Feb 7, 2017

I can rebase this branch, if there is interest from the maintainer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants