Skip to content

Commit

Permalink
[FIX] account: improve rounding methods UI strings
Browse files Browse the repository at this point in the history
The rounding method 'HALF-UP' is confusing for regular users when they
see it in the UI. Replacing the user-facing term by the less specific
'Nearest' is clearer, since people naturally expect that to round halves
up.

Also the other UI strings were in all caps and have been changed to
capitalized strings.

opw-4266444

closes odoo#186279

X-original-commit: bc7b215
Related: odoo/enterprise#73316
Signed-off-by: Dylan Kiss (dyki) <[email protected]>
  • Loading branch information
dylankiss committed Nov 12, 2024
1 parent 4d417f2 commit d9f83b5
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 17 deletions.
39 changes: 23 additions & 16 deletions addons/account/i18n/account.pot
Original file line number Diff line number Diff line change
Expand Up @@ -4911,11 +4911,6 @@ msgstr ""
msgid "DELIVERED DUTY PAID"
msgstr ""

#. module: account
#: model:ir.model.fields.selection,name:account.selection__account_cash_rounding__rounding_method__down
msgid "DOWN"
msgstr ""

#. module: account
#: model:ir.ui.menu,name:account.menu_board_journal_1
msgid "Dashboard"
Expand Down Expand Up @@ -5639,6 +5634,11 @@ msgstr ""
msgid "Domestic country of your accounting"
msgstr ""

#. module: account
#: model:ir.model.fields.selection,name:account.selection__account_cash_rounding__rounding_method__down
msgid "Down"
msgstr ""

#. module: account
#: model:ir.model.fields,field_description:account.field_account_move_send__checkbox_download
#: model:ir.model.fields,field_description:account.field_res_config_settings__invoice_is_download
Expand Down Expand Up @@ -6892,11 +6892,6 @@ msgstr ""
msgid "Growth Comparison"
msgstr ""

#. module: account
#: model:ir.model.fields.selection,name:account.selection__account_cash_rounding__rounding_method__half-up
msgid "HALF-UP"
msgstr ""

#. module: account
#: model:ir.model,name:account.model_ir_http
msgid "HTTP Routing"
Expand Down Expand Up @@ -9312,6 +9307,11 @@ msgstr ""
msgid "Navigate easily through reports and see what is behind the numbers"
msgstr ""

#. module: account
#: model:ir.model.fields.selection,name:account.selection__account_cash_rounding__rounding_method__half-up
msgid "Nearest"
msgstr ""

#. module: account
#: model:ir.model.fields,field_description:account.field_account_bank_statement_line__need_cancel_request
#: model:ir.model.fields,field_description:account.field_account_move__need_cancel_request
Expand Down Expand Up @@ -11993,6 +11993,7 @@ msgstr ""
#. module: account
#. odoo-python
#: code:addons/account/models/account_payment.py:0
#: code:addons/account/wizard/account_payment_register.py:0
#, python-format
msgid "Scan me with your banking app."
msgstr ""
Expand Down Expand Up @@ -14579,7 +14580,6 @@ msgstr ""
msgid "This journal is not in strict mode."
msgstr ""


#. module: account
#: model:ir.model.fields,help:account.field_account_report_line__hide_if_zero
msgid ""
Expand Down Expand Up @@ -15057,11 +15057,6 @@ msgstr ""
msgid "Type of the exception activity on record."
msgstr ""

#. module: account
#: model:ir.model.fields.selection,name:account.selection__account_cash_rounding__rounding_method__up
msgid "UP"
msgstr ""

#. module: account
#. odoo-python
#: code:addons/account/models/account_bank_statement.py:0
Expand Down Expand Up @@ -15238,6 +15233,11 @@ msgstr ""
msgid "UoM"
msgstr ""

#. module: account
#: model:ir.model.fields.selection,name:account.selection__account_cash_rounding__rounding_method__up
msgid "Up"
msgstr ""

#. module: account
#: model_terms:ir.ui.view,arch_db:account.view_move_form
msgid "Update Taxes and Accounts"
Expand Down Expand Up @@ -15969,6 +15969,13 @@ msgid ""
"%s journal."
msgstr ""

#. module: account
#. odoo-python
#: code:addons/account/wizard/account_payment_register.py:0
#, python-format
msgid "You can't create payments for entries belonging to different branches."
msgstr ""

#. module: account
#. odoo-python
#: code:addons/account/wizard/account_payment_register.py:0
Expand Down
2 changes: 1 addition & 1 deletion addons/account/models/account_cash_rounding.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class AccountCashRounding(models.Model):
domain="[('deprecated', '=', False)]",
)
rounding_method = fields.Selection(string='Rounding Method', required=True,
selection=[('UP', 'UP'), ('DOWN', 'DOWN'), ('HALF-UP', 'HALF-UP')],
selection=[('UP', 'Up'), ('DOWN', 'Down'), ('HALF-UP', 'Nearest')],
default='HALF-UP', help='The tie-breaking rule used for float rounding operations')
company_id = fields.Many2one('res.company', related='profit_account_id.company_id')

Expand Down

0 comments on commit d9f83b5

Please sign in to comment.