Use function-style tags for options #78
Merged
+264
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thockin
force-pushed
the
validation-gen-th-functional-tags
branch
from
0fecd2d to
291bd6a
Compare
yongruilin
reviewed
Dec 19, 2024
thockin
changed the title
thockin
force-pushed
the
validation-gen-th-functional-tags
branch
4 times, most recently
from
7e85a69 to
fde6b4f
Compare
thockin
force-pushed
the
validation-gen-th-functional-tags
branch
from
fde6b4f to
2175c02
Compare
thockin
changed the title
thockin
force-pushed
the
validation-gen-th-functional-tags
branch
from
2175c02 to
30c8385
Compare
|
Gengo is merged and vendor is updated here - ready for review. |
|
Could you rebase to include the github action change to let the CI run correctly? Separate discussion: Did we think of having this work with compatibility version? e.g. |
yongruilin
reviewed
Jan 7, 2025
staging/src/k8s.io/code-generator/cmd/validation-gen/validators/options.go
Show resolved
Hide resolved
This defines a parser for tags which takes a single Go-style identifier argument (but leaves room for better parsing).
thockin
force-pushed
the
validation-gen-th-functional-tags
branch
from
30c8385 to
5054d5a
Compare
what would the semantics of that be? |
|
new push is up with rebase |
|
LGTM
I was thinking that this means the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defines a parser for tags which takes a single Go-style identifier argument (but leaves room for better parsing).