Adding OCI Cloud Controller Manager integration #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilomartinelli
approved these changes
Mar 19, 2022
nom3ad
reviewed
Apr 23, 2022
| @@ -8,6 +8,27 @@ locals { | |||
| compartment_id = oci_identity_compartment._.id | |||
| } | |||
|
|
|||
| # Dynamic groups must be created with a tenancy comportament id | |||
There was a problem hiding this comment.
Dynamic groups and identity_policy should be created in the home region.
https://docs.oracle.com/en-us/iaas/Content/Identity/Tasks/managingregions.htm#The
|
Hi! Sorry that it took me so long to review this 😅 This is neat, but I have two questions:
What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Today, Oracle CCM team released version 0.13.0 with ARM support, so now, it works with Ampere instances.
Important to remember that the maximum supported version of Kubernetes is 1.21
This is my little contribution to integrating this CCM with the project.