Automatically load AMP pages #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified `amplified.js` to use ternary operators Combined `querySelector`s in `amplified.js` Minor Changes
Changed `ampTabs` from array to dictionary Made indentation consistant Added Case for "AMP version not detected" Removed period from `default_title` to match other titles Delete tab information if closed using `chrome.tabs.onRemoved`
|
@heubergen For now I don't have time for it, but you can try doing it yourself, the code is CC0-licensed. |
|
I need to look at it again, just merging it seems not to work :) |
|
FYI I'm going to flip the base license on amplifier to MIT before I take any external commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I added the auto mode to the options, which checks for an amphtml link as soon as the
<head>is loaded, then it stops loading the full page and loads the AMP version instead. This method has a minimal overhead. I reformatted the code and fixed the typos too.