allow icon sizes as strings

jpmorganchase · Oct 5, 2023 · 5d31c31 · 5d31c31 · vercel · Oct 5, 2023
1 parent fd2d055
commit 5d31c31
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/packages/components/src/Icon/index.tsx b/packages/components/src/Icon/index.tsx
@@ -7,9 +7,15 @@ export interface IconProps {
   /** Name of the icon */
   name: IconNames;
   /** Size of Icon */
-  size?: number;
+  size?: number | 'small' | 'medium' | 'large';
 }
 
+const iconSizeMap = {
+  small: 1,
+  medium: 2,
+  large: 3
+};
+
 const deprecatedIcons = {
   tick: 'successTick'
 };
@@ -35,9 +41,10 @@ export const Icon: React.FC<React.PropsWithChildren<IconProps>> = ({
     throw new Error(`icon ${currentIconName} is not supported`);
   }
   const IconComponent = icons[currentIconName];
+  const iconSize = typeof size === 'string' ? iconSizeMap[size] : size;
   return (
     <span className={className} {...rest}>
-      <IconComponent size={size} />
+      <IconComponent size={iconSize} />
     </span>
   );
 };
diff --git a/packages/components/src/Tag/index.tsx b/packages/components/src/Tag/index.tsx
@@ -18,12 +18,6 @@ export interface TagProps {
   size?: Size;
 }
 
-const iconSizeMap = {
-  small: 1,
-  medium: 2,
-  large: 3
-};
-
 /**
  * Renders a Tag.
  * @example
@@ -59,7 +53,7 @@ export const Tag: React.FC<React.PropsWithChildren<TagProps>> = ({
     >
       {iconName && (
         <span className={styles.icon}>
-          <Icon name={iconName} size={iconSizeMap[size]} />
+          <Icon name={iconName} size={size} />
         </span>
       )}
       {label}