Remove overrides for Salt Icon color #486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 14d4416 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mark-tate
reviewed
Sep 18, 2023
libertymayc
approved these changes
Sep 18, 2023
DavieReid
approved these changes
Sep 19, 2023
DavieReid
requested changes
Sep 19, 2023
There was a problem hiding this comment.
This isnt building...
@jpmorganchase/mosaic-theme:build: ✘ [ERROR] [plugin vanilla-extract] Build failed with 1 error:
--
08:56:20.773 | @jpmorganchase/mosaic-theme:build: src/icon/icons.css.ts:5:9: error: No matching export in "src/salt/index.ts" for import "iconSizeVars"
…ted in the default state
Sources were being started/stopped but the pages were never being added to the global filesystem.
By adding the `allowMultiple` option to a plugins definition in the `mosaic.config.mjs` file, multiple instances of that plugin can be loaded by Mosaic. `allowMultiple` *must* be added to all module definition instances and takes priority over module definitions that do not have it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the overrides for Salt Icon color. The override is stopping the color prop from working on the Salt site, (added here: jpmorganchase/salt-ds#2462).
The Salt icon will now use currentColor by default, so the override shouldn't be needed anymore.