489 link editing #490
Merged
489 link editing #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
🦋 Changeset detectedLatest commit: cedf6f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tambo
requested changes
Sep 22, 2023
packages/content-editor-plugin/src/components/Toolbar/InsertLink.tsx
Outdated
Show resolved
Hide resolved
DavieReid
force-pushed
the
489-link-editing
branch
from
c3d7107 to
cedf6f0
Compare
Pull Request Test Coverage Report for Build 6275528180
💛 - Coveralls |
tambo
approved these changes
Sep 22, 2023
ZarkoPernar
reviewed
Sep 22, 2023
| </div> | ||
| </DialogContent> | ||
| <DialogActions> | ||
| <ButtonBar> |
There was a problem hiding this comment.
No need for ButtonBar in actions right now. Although the actions don't have the full functionality of the old button bar. But if this works well then maybe leave it. I haven't tried it myself.
There was a problem hiding this comment.
Noted...will address in a future PR
ZarkoPernar
approved these changes
Sep 22, 2023
joshwooding
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.