Add sideEffects *.css to package.json files (#4497)

jpmorganchase · Dec 13, 2024 · 0a5b68b · 0a5b68b
1 parent 86d2a28
commit 0a5b68b
Show file tree

Hide file tree

Showing 7 changed files with 32 additions and 8 deletions.
diff --git a/.changeset/perfect-icons-whisper.md b/.changeset/perfect-icons-whisper.md
@@ -0,0 +1,10 @@
+---
+"@salt-ds/ag-grid-theme": patch
+"@salt-ds/countries": patch
+"@salt-ds/icons": patch
+"@salt-ds/theme": patch
+"@salt-ds/core": patch
+"@salt-ds/lab": patch
+---
+
+Marked CSS files as having side effects. This fixes Webpack tree-shaking CSS files when `sideEffects: true` is not set on style-loader rules.
diff --git a/packages/ag-grid-theme/package.json b/packages/ag-grid-theme/package.json
@@ -13,6 +13,9 @@
     "/fonts",
     "/salt-ag-theme.css"
   ],
+  "sideEffects": [
+    "*.css"
+  ],
   "scripts": {
     "build": "yarn node ./scripts/build.mjs",
     "build-watch": "yarn node ./scripts/build.mjs --watch"

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -9,7 +9,9 @@
   },
   "bugs": "https://github.com/jpmorganchase/salt-ds/issues",
   "main": "src/index.ts",
-  "sideEffects": false,
+  "sideEffects": [
+    "*.css"
+  ],
   "dependencies": {
     "@floating-ui/react": "^0.26.5",
     "@salt-ds/icons": "workspace:^",

diff --git a/packages/countries/package.json b/packages/countries/package.json
@@ -9,12 +9,14 @@
   },
   "bugs": "https://github.com/jpmorganchase/salt-ds/issues",
   "main": "src/index.ts",
-  "sideEffects": false,
   "files": [
     "saltCountries.css",
     "saltSharpCountries.css",
     "css"
   ],
+  "sideEffects": [
+    "*.css"
+  ],
   "scripts": {
     "build": "yarn clean && yarn build:countries && yarn node ../../scripts/build.mjs",
     "build:countries": "node ./scripts/generateCountrySymbol.mjs '*.svg'",

diff --git a/packages/icons/package.json b/packages/icons/package.json
@@ -9,11 +9,13 @@
   },
   "bugs": "https://github.com/jpmorganchase/salt-ds/issues",
   "main": "src/index.ts",
-  "sideEffects": false,
   "files": [
     "css",
     "saltIcons.css"
   ],
+  "sideEffects": [
+    "*.css"
+  ],
   "scripts": {
     "build": "yarn clean && yarn build:icons && yarn node ../../scripts/build.mjs",
     "build:icons": "yarn node ./scripts/generateIcons.mjs '*.svg'",

diff --git a/packages/lab/package.json b/packages/lab/package.json
@@ -9,7 +9,12 @@
   },
   "bugs": "https://github.com/jpmorganchase/salt-ds/issues",
   "main": "src/index.ts",
-  "sideEffects": false,
+  "files": [
+    "css"
+  ],
+  "sideEffects": [
+    "*.css"
+  ],
   "dependencies": {
     "@floating-ui/react": "^0.26.5",
     "@salt-ds/core": "workspace:^",
@@ -56,8 +61,5 @@
   "scripts": {
     "build": "yarn node ../../scripts/build.mjs",
     "bundle:css": "yarn node ./scripts/build.mjs"
-  },
-  "files": [
-    "css"
-  ]
+  }
 }
diff --git a/packages/theme/package.json b/packages/theme/package.json
@@ -13,6 +13,9 @@
     "/index.css",
     "/css"
   ],
+  "sideEffects": [
+    "*.css"
+  ],
   "scripts": {
     "build": "yarn node ./scripts/build.mjs",
     "build:watch": "yarn node ./scripts/build.mjs --watch"