review comments addressed

jpmorganchase · Oct 7, 2024 · 29c9b74 · 29c9b74
1 parent 5ae70be
commit 29c9b74
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/core/src/avatar/Avatar.tsx b/packages/core/src/avatar/Avatar.tsx
@@ -53,15 +53,17 @@ export const Avatar = forwardRef<HTMLDivElement, AvatarProps>(function Avatar(
     src,
     size = DEFAULT_AVATAR_SIZE,
     style: styleProp,
-    fallbackIcon,
+    fallbackIcon: fallbackIconProp,
     ...rest
   },
   ref,
 ) {
   const targetWindow = useWindow();
   const { UserIcon } = useIcon();
 
-  const fallBackIcon = fallbackIcon || <UserIcon aria-label="User Avatar" />;
+  const fallbackIcon = fallbackIconProp || (
+    <UserIcon aria-label="User Avatar" />
+  );
 
   useComponentCssInjection({
     testId: "salt-avatar",
@@ -105,7 +107,7 @@ export const Avatar = forwardRef<HTMLDivElement, AvatarProps>(function Avatar(
       {...initialsProps}
       {...rest}
     >
-      {children || avatarInitials || fallBackIcon}
+      {children || avatarInitials || fallbackIcon}
     </div>
   );
 });
diff --git a/packages/core/src/navigation-item/NavigationItem.tsx b/packages/core/src/navigation-item/NavigationItem.tsx
@@ -5,7 +5,6 @@ import {
   type MouseEventHandler,
   forwardRef,
 } from "react";
-import { useIcon } from "../semantic-icon-provider";
 import { makePrefixer } from "../utils";
 import { ExpansionIcon } from "./ExpansionIcon";