Fix Combo Box Next onChange using stale values (#2697)

Co-authored-by: Josh Wooding <[email protected]>
jpmorganchase · Nov 10, 2023 · c5aede9 · c5aede9 · vercel · Nov 10, 2023
1 parent 6a0dff7
commit c5aede9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/ninety-queens-retire.md b/.changeset/ninety-queens-retire.md
@@ -0,0 +1,5 @@
+---
+"@salt-ds/lab": patch
+---
+
+Fix Combo Box Next `onChange` using stale values
diff --git a/packages/lab/src/combo-box-next/ComboBoxNext.tsx b/packages/lab/src/combo-box-next/ComboBoxNext.tsx
@@ -196,7 +196,7 @@ export const ComboBoxNext = forwardRef(function ComboBoxNext<T>(
   const getFilteredSource = () => {
     if (!source) return null;
     if (selectedItem && inputValue === selectedItem) return source;
-    return itemFilter && itemFilter(source, inputValue);
+    return itemFilter?.(source, inputValue);
   };
   const filteredSource = getFilteredSource();
 
@@ -214,7 +214,7 @@ export const ComboBoxNext = forwardRef(function ComboBoxNext<T>(
         setHighlightedItem(filteredSource[0] as unknown as string);
       }
     }
-    onInputChange?.(event, { value: inputValue ?? "" });
+    onInputChange?.(event, { value: value ?? "" });
   };
 
   const adornment = open ? (