Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support status color for FormFieldHelperText #3540

Closed
1 task
joshwooding opened this issue Jun 10, 2024 · 6 comments
Closed
1 task

Support status color for FormFieldHelperText #3540

joshwooding opened this issue Jun 10, 2024 · 6 comments
Assignees

Comments

@joshwooding
Copy link
Contributor

Area

UI Components

The problem

With #3308 complete, it's now possible to support status color in text. This means we can style helper text with the FormField status.

The solution

.

Alternatives and examples

.

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@joshwooding joshwooding added type: enhancement 💡 New feature or request status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. component: form field and removed status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. labels Jun 10, 2024
@alexmotoc
Copy link
Contributor

I think I have a solution for this, could I pick up this task?

@bhoppers2008
Copy link

Ben to finalise review with @dplsek

@mark-tate
Copy link
Contributor

@dplsek to make a decision by 23/07/24

@dplsek
Copy link

dplsek commented Jul 22, 2024

Please keep status helper text style the same as standard helper text style (italic). The only difference should be the color of the text itself and the addition of the corresponding status icon. The tokens for styling the status text and icon should be as follows:

Icons = decorative tokens: red/orange/green – 500
status-______-foreground-decorative

Text = informative tokens: red/orange/green – 400(dark) and 600(light)
status-______-foreground-informative

@joshwooding
Copy link
Contributor Author

Thanks @dplsek. #3603 is ready for review

@joshwooding
Copy link
Contributor Author

Closed by #3603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

5 participants