Support status color for FormFieldHelperText #3603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 09d7d6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@alexmotoc is attempting to deploy a commit to the FED Team Team on Vercel. A member of the Team first needs to authorize it. |
joshwooding
reviewed
Jun 19, 2024
|
Needs a design review, @jpmorganchase/salt-design . Are we happy with this affecting all helper text? Do we want it to be optional |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shey-v
previously approved these changes
Jun 28, 2024
|
Move to draft as waiting for design discussion. |
joshwooding
force-pushed
the
form-field-helper-status-color
branch
from
358392b to
dbd76c7
Compare
1 task
Co-authored-by: Josh Wooding <[email protected]>
joshwooding
force-pushed
the
form-field-helper-status-color
branch
from
dbd76c7 to
3caf643
Compare
joshwooding
added
the
chromatic
joshwooding
reviewed
Jul 23, 2024
joshwooding
approved these changes
Jul 23, 2024
github-actions
bot
removed
the
chromatic
dplsek
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
colorprop instead of the deprecatedvariant. It should now apply the success/warning/error colour to the helper text based on the form field status.Should address #3540