Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toast's icon in HD is misaligned #3524

Closed
10 tasks
joshwooding opened this issue Jun 5, 2024 · 5 comments · Fixed by #4357
Closed
10 tasks

Toast's icon in HD is misaligned #3524

joshwooding opened this issue Jun 5, 2024 · 5 comments · Fixed by #4357
Assignees
@joshwooding
Labels
component: icon component: toast priority: medium 😠

Comments

@joshwooding
Copy link
Contributor

joshwooding commented Jun 5, 2024 •
edited
Loading

Package name(s)

Core (@salt-ds/core)

Package version(s)

latest

Description

Toast's icon in HD is misaligned

image

Steps to reproduce

https://storybook.saltdesignsystem.com/?path=/story/core-toast--error&globals=density:high

Expected behavior

No response

Operating system

  • macOS
  • Windows
  • Linux
  • iOS
  • Android

Browser

  • Chrome
  • Safari
  • Firefox
  • Edge

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@mark-tate
Copy link
Contributor

no work planned for Toast in Q1, we may pick this up in Q1 or when other Toast work is created

@liamsms
Copy link
Contributor

liamsms commented Oct 29, 2024

Hi - I could pick up this issue

@liamsms liamsms mentioned this issue Oct 29, 2024
Merged
@joshwooding
Copy link
Contributor Author

Hi @liamsms, I think this will need some design input since we should be aligned with what's be spec'd in Figma.

@joshwooding joshwooding self-assigned this Jan 7, 2025
@bhoppers2008
Copy link

@joshwooding to follow up with Darrin and align on strategy.

@joshwooding joshwooding added type: bug 🪲 Something isn't working and removed type: bug 🪲 Something isn't working labels Jan 16, 2025
@mark-tate
Copy link
Contributor

Tecno goal:
Align code to Figma, PR up, aim to merge by EOS
@pseys to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshwooding joshwooding

Labels
component: icon component: toast priority: medium 😠
Projects
Salt - Components, Patterns and Theming
Status: Green
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix HD Toast icon alignment liamsms/salt-ds
4 participants
@mark-tate @joshwooding @bhoppers2008 @liamsms