Fix HD Toast icon alignment #4357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2392f35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@liamsms is attempting to deploy a commit to the FED Team Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks @liamsms, I've left a comment in the issue but I think we'll need design feedback since we should align to what's been done in Figma. |
joshwooding
reviewed
Jan 21, 2025
joshwooding
force-pushed
the
toast-icon-alignment
branch
from
9a58999 to
e4ff503
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joshwooding
added
the
chromatic
github-actions
bot
removed
the
chromatic
joshwooding
added
the
chromatic
github-actions
bot
removed
the
chromatic
joshwooding
approved these changes
Jan 21, 2025
pseys
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3524
In the Figma spec, the high density icon has a
padding-topvalue of1px. The other densities have a value of2px.In the code, the
padding-topvalue is combined with themargin-topvalue, however all densities have a value of2px.I've updated the CSS to use
1pxinstead of2pxwhen high density is selected.