Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Spacing foundation to spacing-950 #4608

Closed
pseys opened this issue Jan 22, 2025 · 5 comments · Fixed by #4636
Closed

Extend Spacing foundation to spacing-950 #4608

pseys opened this issue Jan 22, 2025 · 5 comments · Fixed by #4636
Assignees
Labels
package: theme Theme package

Comments

@pseys
Copy link
Contributor

pseys commented Jan 22, 2025

As part of the Pokemon project we have identified the need to extend the spacing foundation. Instead of stopping at --spacing-400, the foundation should increase to --spacing-950

Token HD MD TD LD
--spacing-450 18 36 54 72
--spacing-500 20 40 60 80
--spacing-550 22 44 66 88
--spacing-600 24 48 72 96
--spacing-650 26 52 78 104
--spacing-700 28 56 84 112
--spacing-750 30 60 90 120
--spacing-800 32 64 96 128
--spacing-850 34 68 102 136
--spacing-900 36 72 108 144
--spacing-950 38 76 114 152

This change needs to be made in code and in Figma.

@pseys pseys changed the title Extend Spacing foundation to spacing-900 Extend Spacing foundation to spacing-950 Jan 22, 2025
@pseys pseys added the package: theme Theme package label Jan 22, 2025
@mark-tate
Copy link
Contributor

added to support pokemon
Basil Goal: to extend tokens and to be published through foundation docs

@mark-tate
Copy link
Contributor

working through other token issues and hope to get to this by EOS

@mark-tate
Copy link
Contributor

PR to be raised by next standup

Spacing foundation docs complete and will be merged alongside change

@mark-tate
Copy link
Contributor

Oregano Goal: will be released by end of wk 1

@pseys
Copy link
Contributor Author

pseys commented Feb 4, 2025

The changes have been made in a Figma branch. As soon as they are pushed in code I'll publish them in Figma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: theme Theme package
Projects
Development

Successfully merging a pull request may close this issue.

4 participants