Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacing foundation updates #4620

Merged
merged 15 commits into from
Feb 5, 2025
Merged

Spacing foundation updates #4620

merged 15 commits into from
Feb 5, 2025
+69 −101

Conversation

amritadesmet
Copy link
Contributor

In relation to #4554

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f80b24d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 1:45pm

@amritadesmet amritadesmet mentioned this pull request Jan 27, 2025
Closed
2 tasks
mark-tate
mark-tate approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@mark-tate mark-tate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will will need another iteration after pokemon, we can also use pokemon to discuss the challenges of using foundation values directly in code.

Left a few cleanup comments

mark-tate
mark-tate previously approved these changes Jan 28, 2025
View reviewed changes
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Feb 4, 2025
joshwooding
joshwooding previously approved these changes Feb 4, 2025
View reviewed changes
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Feb 4, 2025
@joshwooding
Copy link
Contributor

@amritadesmet Does this still need changes from the feedback you've received? If so can you move it back to draft please

amritadesmet and others added 15 commits February 5, 2025 13:37
@amritadesmet @joshwooding
spacing-pg
be1d957
@amritadesmet @joshwooding
Update spacing.mdx
ca1a474 
updated a description
@amritadesmet @joshwooding
Update spacing.mdx
91b9137 
corrected formatting
@joshwooding
prettier
5419943
@amritadesmet @joshwooding
Update site/docs/foundations/spacing.mdx
1208cd7 
Co-authored-by: Josh Wooding <[email protected]>
@amritadesmet @joshwooding
Update site/docs/foundations/spacing.mdx
8e786e9 
Co-authored-by: Josh Wooding <[email protected]>
@amritadesmet @joshwooding
Update site/docs/foundations/spacing.mdx
b9457e5 
Co-authored-by: Josh Wooding <[email protected]>
@amritadesmet @joshwooding
Update spacing.mdx
a9cd8b9 
updated a definition
@amritadesmet @joshwooding
Update spacing.mdx
45ff83c 
incorporated feedback
@amritadesmet @joshwooding
Update spacing.mdx
1dad145 
Included Mark's edits
@amritadesmet @joshwooding
Update spacing.mdx
c7f2fa0 
Formatting
@tayyabataimur @joshwooding
Fix lint issues
284bde4
@amritadesmet @joshwooding
Update spacing.mdx
67ab9bb 
Included feedback from Darrin
@joshwooding
Prettier
552ce46
@amritadesmet @joshwooding
Update spacing.mdx
f80b24d 
Included new feedback
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Feb 5, 2025
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Feb 5, 2025
@amritadesmet amritadesmet merged commit 114df0b into main Feb 5, 2025
14 of 15 checks passed
@amritadesmet amritadesmet deleted the spacing-pg-updates branch February 5, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-tate mark-tate mark-tate left review comments

@Fercas123 Fercas123 Fercas123 approved these changes

@joshwooding joshwooding joshwooding approved these changes

@libertymayc libertymayc libertymayc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amritadesmet @joshwooding @mark-tate @Fercas123 @libertymayc @tayyabataimur