[Ag Grid Theme] Ag grid v30 - no sass #2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
origami-z
approved these changes
Nov 23, 2023
| content: "\e922"; | ||
| } | ||
|
|
||
| /* [class*="ag-theme-uitk"] .ag-icon-filter-clear:before { |
There was a problem hiding this comment.
yes. Also waiting for design to provide a grab icon (for the drag & drop rows)
| @@ -60,7 +60,7 @@ export function useAgGridHelpers({ | |||
| } | |||
| }, [density, agThemeName, compact]); | |||
|
|
|||
| const className = `${agThemeName}-${density}${ | |||
| const className = `${agThemeName}${ | |||
There was a problem hiding this comment.
Worth calling out in noticeable places
There was a problem hiding this comment.
not sure I understand
|
The vercel build fails with:
|
sorted. thanks |
origami-z
pushed a commit
that referenced
this pull request
Apr 3, 2024
Co-authored-by: Josh Wooding <[email protected]>
origami-z
pushed a commit
that referenced
this pull request
Apr 4, 2024
Co-authored-by: Josh Wooding <[email protected]>
origami-z
pushed a commit
that referenced
this pull request
Apr 11, 2024
Co-authored-by: Josh Wooding <[email protected]>
origami-z
pushed a commit
that referenced
this pull request
Apr 25, 2024
Co-authored-by: Josh Wooding <[email protected]>
origami-z
pushed a commit
that referenced
this pull request
Apr 29, 2024
Ag grid theme - add cypress tests (#2614) [Ag Grid Theme] test UITK theme (#2699) [Ag Grid Theme] Ag grid v30 - no sass (#2661) Co-authored-by: Josh Wooding <[email protected]> use content characteristic Create tasty-trains-cover.md Update tasty-trains-cover.md fixes AG Grid Theme site docs (#2796) Update build.mjs Update package.json Ag grid test range selection (#2827) Ag grid theme tooltip test (#2654) [AG Grid Theme] Update icons (#2849) fix editable cell bug Fixed missing padding and focus ring on focused editable cell. Fixed wrong background and missing corner flag when editable cell loses focus. Update salt-ag-grid-theme.css Update salt-ag-grid-theme.css
origami-z
pushed a commit
that referenced
this pull request
Apr 29, 2024
Ag grid theme - add cypress tests (#2614) [Ag Grid Theme] test UITK theme (#2699) [Ag Grid Theme] Ag grid v30 - no sass (#2661) Co-authored-by: Josh Wooding <[email protected]> use content characteristic Create tasty-trains-cover.md Update tasty-trains-cover.md fixes AG Grid Theme site docs (#2796) Update build.mjs Update package.json Ag grid test range selection (#2827) Ag grid theme tooltip test (#2654) [AG Grid Theme] Update icons (#2849) fix editable cell bug Fixed missing padding and focus ring on focused editable cell. Fixed wrong background and missing corner flag when editable cell loses focus. Update salt-ag-grid-theme.css Update salt-ag-grid-theme.css
origami-z
pushed a commit
that referenced
this pull request
May 3, 2024
Ag grid theme - add cypress tests (#2614) [Ag Grid Theme] test UITK theme (#2699) [Ag Grid Theme] Ag grid v30 - no sass (#2661) Co-authored-by: Josh Wooding <[email protected]> use content characteristic Create tasty-trains-cover.md Update tasty-trains-cover.md fixes AG Grid Theme site docs (#2796) Update build.mjs Update package.json Ag grid test range selection (#2827) Ag grid theme tooltip test (#2654) [AG Grid Theme] Update icons (#2849) fix editable cell bug Fixed missing padding and focus ring on focused editable cell. Fixed wrong background and missing corner flag when editable cell loses focus. Update salt-ag-grid-theme.css Update salt-ag-grid-theme.css
origami-z
pushed a commit
that referenced
this pull request
May 9, 2024
Ag grid theme - add cypress tests (#2614) [Ag Grid Theme] test UITK theme (#2699) [Ag Grid Theme] Ag grid v30 - no sass (#2661) Co-authored-by: Josh Wooding <[email protected]> use content characteristic Create tasty-trains-cover.md Update tasty-trains-cover.md fixes AG Grid Theme site docs (#2796) Update build.mjs Update package.json Ag grid test range selection (#2827) Ag grid theme tooltip test (#2654) [AG Grid Theme] Update icons (#2849) fix editable cell bug Fixed missing padding and focus ring on focused editable cell. Fixed wrong background and missing corner flag when editable cell loses focus. Update salt-ag-grid-theme.css Update salt-ag-grid-theme.css
origami-z
pushed a commit
that referenced
this pull request
May 13, 2024
Ag grid theme - add cypress tests (#2614) [Ag Grid Theme] test UITK theme (#2699) [Ag Grid Theme] Ag grid v30 - no sass (#2661) Co-authored-by: Josh Wooding <[email protected]> use content characteristic Create tasty-trains-cover.md Update tasty-trains-cover.md fixes AG Grid Theme site docs (#2796) Update build.mjs Update package.json Ag grid test range selection (#2827) Ag grid theme tooltip test (#2654) [AG Grid Theme] Update icons (#2849) fix editable cell bug Fixed missing padding and focus ring on focused editable cell. Fixed wrong background and missing corner flag when editable cell loses focus. Update salt-ag-grid-theme.css Update salt-ag-grid-theme.css
origami-z
pushed a commit
that referenced
this pull request
May 17, 2024
Ag grid theme - add cypress tests (#2614) [Ag Grid Theme] test UITK theme (#2699) [Ag Grid Theme] Ag grid v30 - no sass (#2661) Co-authored-by: Josh Wooding <[email protected]> use content characteristic Create tasty-trains-cover.md Update tasty-trains-cover.md fixes AG Grid Theme site docs (#2796) Update build.mjs Update package.json Ag grid test range selection (#2827) Ag grid theme tooltip test (#2654) [AG Grid Theme] Update icons (#2849) fix editable cell bug Fixed missing padding and focus ring on focused editable cell. Fixed wrong background and missing corner flag when editable cell loses focus. Update salt-ag-grid-theme.css Update salt-ag-grid-theme.css
origami-z
pushed a commit
that referenced
this pull request
May 22, 2024
Ag grid theme - add cypress tests (#2614) [Ag Grid Theme] test UITK theme (#2699) [Ag Grid Theme] Ag grid v30 - no sass (#2661) Co-authored-by: Josh Wooding <[email protected]> use content characteristic Create tasty-trains-cover.md Update tasty-trains-cover.md fixes AG Grid Theme site docs (#2796) Update build.mjs Update package.json Ag grid test range selection (#2827) Ag grid theme tooltip test (#2654) [AG Grid Theme] Update icons (#2849) fix editable cell bug Fixed missing padding and focus ring on focused editable cell. Fixed wrong background and missing corner flag when editable cell loses focus. Update salt-ag-grid-theme.css Update salt-ag-grid-theme.css
origami-z
pushed a commit
that referenced
this pull request
May 23, 2024
Ag grid theme - add cypress tests (#2614) [Ag Grid Theme] test UITK theme (#2699) [Ag Grid Theme] Ag grid v30 - no sass (#2661) Co-authored-by: Josh Wooding <[email protected]> use content characteristic Create tasty-trains-cover.md Update tasty-trains-cover.md fixes AG Grid Theme site docs (#2796) Update build.mjs Update package.json Ag grid test range selection (#2827) Ag grid theme tooltip test (#2654) [AG Grid Theme] Update icons (#2849) fix editable cell bug Fixed missing padding and focus ring on focused editable cell. Fixed wrong background and missing corner flag when editable cell loses focus. Update salt-ag-grid-theme.css Update salt-ag-grid-theme.css
origami-z
pushed a commit
that referenced
this pull request
May 23, 2024
Ag grid theme - add cypress tests (#2614) [Ag Grid Theme] test UITK theme (#2699) [Ag Grid Theme] Ag grid v30 - no sass (#2661) Co-authored-by: Josh Wooding <[email protected]> use content characteristic Create tasty-trains-cover.md Update tasty-trains-cover.md fixes AG Grid Theme site docs (#2796) Update build.mjs Update package.json Ag grid test range selection (#2827) Ag grid theme tooltip test (#2654) [AG Grid Theme] Update icons (#2849) fix editable cell bug Fixed missing padding and focus ring on focused editable cell. Fixed wrong background and missing corner flag when editable cell loses focus. Update salt-ag-grid-theme.css Update salt-ag-grid-theme.css
origami-z
pushed a commit
that referenced
this pull request
May 23, 2024
Ag grid theme - add cypress tests (#2614) [Ag Grid Theme] test UITK theme (#2699) [Ag Grid Theme] Ag grid v30 - no sass (#2661) Co-authored-by: Josh Wooding <[email protected]> use content characteristic Create tasty-trains-cover.md Update tasty-trains-cover.md fixes AG Grid Theme site docs (#2796) Update build.mjs Update package.json Ag grid test range selection (#2827) Ag grid theme tooltip test (#2654) [AG Grid Theme] Update icons (#2849) fix editable cell bug Fixed missing padding and focus ring on focused editable cell. Fixed wrong background and missing corner flag when editable cell loses focus. Update salt-ag-grid-theme.css Update salt-ag-grid-theme.css
origami-z
pushed a commit
that referenced
this pull request
May 24, 2024
Ag grid theme - add cypress tests (#2614) [Ag Grid Theme] test UITK theme (#2699) [Ag Grid Theme] Ag grid v30 - no sass (#2661) Co-authored-by: Josh Wooding <[email protected]> use content characteristic Create tasty-trains-cover.md Update tasty-trains-cover.md fixes AG Grid Theme site docs (#2796) Update build.mjs Update package.json Ag grid test range selection (#2827) Ag grid theme tooltip test (#2654) [AG Grid Theme] Update icons (#2849) fix editable cell bug Fixed missing padding and focus ring on focused editable cell. Fixed wrong background and missing corner flag when editable cell loses focus. Update salt-ag-grid-theme.css Update salt-ag-grid-theme.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2602
Storybook Preview: #2661 (comment)